[Revisor-users] Revisor from git (20071127) crashes

[Jeroen van Meeuwen]

Hi Dmitry,

these errors have both been fixed now;

http://git.fedoraproject.org/?p=hosted/revisor;a=commit;h=c35cb7115e10b99261622e6a9f27d7acaec51dbb

Kind regards,

Jeroen van Meeuwen
-kanarip

Dmitry Artamonow wrote:
> I tried revisor from git fetched today (20071127), and it crashes with
> following traceback on making F7 DVD-install disc (fedora-7-gold.cfg;
> "Use repositories configured in kickstart", "Use package manifest from 
> kickstart", "Include Kickstart file on Install Media" and "Set installer 
> to boot with kickstart" options are set):
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/load_kickstart.py", line
>  202, in button_forward_clicked
>     self.gui.displayReadyScreen()
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/__init__.py", line 304, 
> in displayReadyScreen
>     self.ReadyScreen = ready_screen.ReadyScreen(self)
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/ready_screen.py", line 1
> 04, in __init__
>     self.base.pkglist_from_ksdata(groupList=groupList, packageList=packageList, 
> excludedList=excludedList, ignore_list=self.cfg.yumobj.tsInfo.pkgdict.keys())
>   File "/usr/lib/python2.5/site-packages/revisor/base.py", line 271, in pkglist_
> from_ksdata
>     self.pkglist_from_ksdata_normal(groupList, packageList, excludedList, ignore
> _list)
>   File "/usr/lib/python2.5/site-packages/revisor/base.py", line 466, in pkglist_
> from_ksdata_normal
>     self.log.debug(_("Apparently trying to exclude a package that is not availab
> le in the repositories loaded, or hasn't been added to the transaction: ") % e.v
> alue, level = 4)
> TypeError: not all arguments converted during string formatting
> 
> 
> I fixed this bug by using following changes:
> 
> diff --git a/revisor/base.py b/revisor/base.py
> index e519baf..2819660 100644
> --- a/revisor/base.py
> +++ b/revisor/base.py
> @@ -463,7 +463,7 @@ class RevisorBase:
>                      self.log.debug(_("From Excludes: Removing %s-%s:%s-%s.%s from transaction") % (po.name, po.epoch, po.version, po.release, po.arch), level = 8)
>                      self.cfg.yumobj.tsInfo.remove(po.pkgtup)
>              except yum.Errors.PackageSackError, e:
> -                self.log.debug(_("Apparently trying to exclude a package that is not available in the repositories loaded, or hasn't been added to the transaction: ") % e.value, level = 4)
> +                self.log.debug(_("Apparently trying to exclude a package that is not available in the repositories loaded, or hasn't been added to the transaction: %s") % e.value, level = 4)
>              except:
>                  pass
>              pbar.set_fraction(current/total)
> 
> 
> But then, sadly, revisor crashed again in another place: 
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/ready_screen.py", line 177, in button_forward_clicked
>     self.gui.displayBuildMedia()
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/__init__.py", line 308, in displayBuildMedia
>     self.BuildMedia = build_media.BuildMedia(self)
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/build_media.py", line 57, in __init__
>     self.set_task_list()
>   File "/usr/lib/python2.5/site-packages/revisor/modgui/build_media.py", line 117, in set_task_list
>     if len(self.cfg.cobbler_add_distro) > 0:
> AttributeError: ConfigStore instance has no attribute 'cobbler_add_distro'
> 
> I didn't investigate further.
> 
> P.S.
> My host system is F7 with all updates, revisor built using instructions from
> http://revisor.fedoraunity.org/documentation/building-revisor-from-source
> 
> --
> Best regards,
> Dmitry 'MAD' Artamonow
> 
> _______________________________________________
> Revisor-users mailing list
> Revisor-users at fedoraunity.org
> http://lists.fedoraunity.org/mailman/listinfo/revisor-users